Some of the diffs in IE9 contain black areas. This is caused by Browserstack, not the fonts.

It happened for NanumMyeongjo-Bold.

When I rerun it through diffbrowsers, its fine.

I'll send a mail to the Browserstack team

Ok, I've added all the other families apart from:

• Gaeugu
• Sunf
• KoreaDokdo
• KoreanHBSJ
• KoreanStirr

Gaeugu and Sunf don't have a Regular weight. They do have Mediums weights. @davelab6 shall I rename the Medium weights to Regular?

I think we should rename the fonts which have "Korea" in the name.

Still keep this open. I need to do further tests. I've updated the Nanum fonts so I'd like to show theirs been an improvement.

shall I rename the Medium weights to Regular?

Yes :) cc @aaronbell

I don't think there'd be issues with switching Medium to Regular (where no Regular exists).

I'm going to hold off merging this until the family names are confirmed :)

Just pushed an update which updates the font names.

Please don't merge this yet. I'm investigating an installation warning on OS X.

The Font Book error message is caused when font nametable records are empty.

e.g

''
u'Yeon Sung'
u'Regular'
u'1.00;SAND;YeonSung-Regular'
u'Yeon Sung Regular'
u'Version 1.00'
u'YeonSung-Regular'
u'This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL'
''
u'Yeon Sung'
u'Regular'
u'1.00;SAND;YeonSung-Regular'
u'Yeon Sung Regular'
u'Version 1.00'
u'YeonSung-Regular'
u'This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is available with a FAQ at: http://scripts.sil.org/OFL'
u'http://scripts.sil.org/OFL'

Many of the fonts in this pr have blank copyright strings. @davelab6 shall I remove the record or should I insert a placeholder like "Copyright the {{ Family }} Project Authors". Either way, it will solve this issue

Project authors please

@davelab6 I'm done but have a few questions.

in ofl/hanna I added the suffix .korean to the existing font which is served on early access

Is this correct?

I also think I should squash these commits and write a good pr message outlining what we've done.

Cute Font also fails ots so I have removed it. Round tripping ttx did not solve it. Shall i readd it anyway?

The fonts already on Early Access should be dealt with in another PR.

Nothing that fails OTS should be added.

The fonts already on Early Access should be dealt with in another PR.

Nothing that fails OTS should be added.

Ok, here's my plan.

1. Do not PR Hanna since it conflicts with the early access family. I checked Early Access and Hanna is the only conflict we have.
2. Keep Cute Font out because it fails OTS
3. Squash these prs and write meaningful commit msg

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@m4rc1e is this ready to merge?

Yes

@davelab6 All families are now added.

CuteFont works just fine with the removed GPOS table.

Win 7 IE9

• Copyright notice in Black Han Sans was bad
• Font file name mismatches with what we have in METADATA.pb (Single Day, Hi Melody, Poor Story, Gamja Flower)
• fsSelection failures
  • NanumGothic-ExtraBold.ttf [fsSelection bold should be 1, is 0]
  • NanumMyeongjo-ExtraBold.ttf [fsSelection bold should be 1, is 0]
  • NanumMyeongjo-Bold.ttf [fsSelection bold should be 0, is 1]
  • NanumGothic-Bold.ttf [fsSelection bold should be 0, is 1]

I've started collecting my adhoc font engineering scripts

The scripts for this project can be found here